Fix #23 stop assigning list from list.append - #24
Merged
Conversation
2 tasks
|
@GuruM (since you've reviewed/merged PRs in this repo recently): what is the process for getting review on community-submitted PRs? |
GuruM
approved these changes
Dec 1, 2025
Contributor
Author
|
Awesome! Thanks @GuruM, now we can go back to the maintained version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fixes dbt-labs/dbt-core#13115
Change
{% set columns = columns.append(...) %}to{% do columns.append(...) %}Why Do We Need These Changes
Otherwise dbt-fusion won't work with dbt-expectations. They said they don't plan on fixing dbt-labs/dbt-core#13522, which seems reasonable.
Reviewers
@tpoll @gusvargas